Comments on: Monkey patching ActiveRecord to automatically release connections http://coderrr.wordpress.com/2009/01/16/monkey-patching-activerecord-to-automatically-release-connections/ pronounced "coder" not "code err" (extended r optional) Sun, 20 Dec 2009 10:03:37 +0000 http://wordpress.com/ hourly 1 By: coderrr http://coderrr.wordpress.com/2009/01/16/monkey-patching-activerecord-to-automatically-release-connections/#comment-1685 coderrr Mon, 06 Jul 2009 20:06:49 +0000 http://coderrr.wordpress.com/?p=491#comment-1685 sure is, i have my doubts that'll be changing anytime soon. if you care enough go make a ruckus about how AR needs to have this functionality built into it :) sure is, i have my doubts that’ll be changing anytime soon. if you care enough go make a ruckus about how AR needs to have this functionality built into it :)

]]> By: pauliephonic http://coderrr.wordpress.com/2009/01/16/monkey-patching-activerecord-to-automatically-release-connections/#comment-1684 pauliephonic Mon, 06 Jul 2009 20:04:02 +0000 http://coderrr.wordpress.com/?p=491#comment-1684 Is this patch still required for the latest version of ActiveRecord? I, like a previous poster am using Ramaze and it's site still mentions the patch. Cheers, P Is this patch still required for the latest version of ActiveRecord?

I, like a previous poster am using Ramaze and it’s site still mentions the patch.

Cheers, P

]]> By: ActiveRecord’s with_connection is now useful! « coderrr http://coderrr.wordpress.com/2009/01/16/monkey-patching-activerecord-to-automatically-release-connections/#comment-1350 ActiveRecord’s with_connection is now useful! « coderrr Tue, 05 May 2009 22:27:23 +0000 http://coderrr.wordpress.com/?p=491#comment-1350 [...] actually to have wrap all your code in those annoying blocks, you can check out this monkeypatch (blog post here) which essentially wraps all DB touching ActiveRecord methods with with_connection for you. [...] [...] actually to have wrap all your code in those annoying blocks, you can check out this monkeypatch (blog post here) which essentially wraps all DB touching ActiveRecord methods with with_connection for you. [...]

]]> By: coderrr http://coderrr.wordpress.com/2009/01/16/monkey-patching-activerecord-to-automatically-release-connections/#comment-1292 coderrr Sun, 22 Mar 2009 09:19:03 +0000 http://coderrr.wordpress.com/?p=491#comment-1292 np np

]]> By: Sam http://coderrr.wordpress.com/2009/01/16/monkey-patching-activerecord-to-automatically-release-connections/#comment-1291 Sam Sun, 22 Mar 2009 08:59:54 +0000 http://coderrr.wordpress.com/?p=491#comment-1291 That works great now! Thanks a lot for your help. That works great now! Thanks a lot for your help.

]]> By: coderrr http://coderrr.wordpress.com/2009/01/16/monkey-patching-activerecord-to-automatically-release-connections/#comment-1290 coderrr Sun, 22 Mar 2009 03:20:15 +0000 http://coderrr.wordpress.com/?p=491#comment-1290 Ok so after some investigation I found that because of how validations (and ActiveSupport callbacks) work, it's actually not possible to wrap a validation method. (MIGHT be possible with some extremely dirty hax) So the best thing here would be to just wrap AR::Base#valid?: ActiveRecord::Base => [:quoted_id, :valid?], I've also updated the file on github. Ok so after some investigation I found that because of how validations (and ActiveSupport callbacks) work, it’s actually not possible to wrap a validation method. (MIGHT be possible with some extremely dirty hax)

So the best thing here would be to just wrap AR::Base#valid?:

ActiveRecord::Base => [:quoted_id, :valid?],

I’ve also updated the file on github.

]]> By: Sam http://coderrr.wordpress.com/2009/01/16/monkey-patching-activerecord-to-automatically-release-connections/#comment-1289 Sam Sat, 21 Mar 2009 21:42:31 +0000 http://coderrr.wordpress.com/?p=491#comment-1289 Call stack for the first error is below (the second one is much the same). The notable difference is that you call save! which in turn calls transaction, whereas I call valid? directly, and that doesn't call transaction. My version of the patch is exactly as downloaded - no modifications. connection called outside of cleanup_connection block /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:728:in `validates_uniqueness_of' /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:400:in `validates_each' /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:397:in `each' /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:397:in `validates_each' /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:182:in `call' /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:182:in `evaluate_method' /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:166:in `call' /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:90:in `run' /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:90:in `each' /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:90:in `send' /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:90:in `run' /usr/local/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:277:in `run_callbacks' /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:1029:in `valid_without_callbacks?' /usr/local/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/callbacks.rb:286:in `valid?' /Users/me/Dev/Ruby/Test_trunk/lib/crud/crud_instance_methods.rb:76:in `edit_submit' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/template.rb:63:in `__send__' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/template.rb:63:in `render_method' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/template.rb:48:in `result_and_file' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/template.rb:40:in `reaction_or_file' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/template.rb:71:in `wrap_compile' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/template/ezamar.rb:23:in `transform' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/action/render.rb:115:in `uncached_render' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/action/render.rb:39:in `render' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/action/render.rb:11:in `stack' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/action/render.rb:28:in `render' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/controller.rb:266:in `handle' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher/action.rb:29:in `call' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher/action.rb:28:in `catch' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher/action.rb:28:in `call' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher.rb:122:in `filter' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/snippets/ordered_set.rb:49:in `each' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/snippets/ordered_set.rb:49:in `__send__' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/snippets/ordered_set.rb:49:in `method_missing' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher.rb:121:in `filter' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher.rb:109:in `dispatch' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher.rb:108:in `catch' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher.rb:108:in `dispatch' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher.rb:107:in `catch' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher.rb:107:in `dispatch' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher.rb:78:in `general_dispatch' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher.rb:53:in `call' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/current.rb:19:in `call' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/reloader.rb:84:in `call' /usr/local/lib/ruby/gems/1.8/gems/rack-0.9.1/lib/rack/showstatus.rb:20:in `call' /usr/local/lib/ruby/gems/1.8/gems/rack-0.9.1/lib/rack/showexceptions.rb:23:in `call' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/adapter/base.rb:121:in `respond' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/snippets/ramaze/state.rb:29:in `initialize' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/snippets/ramaze/state.rb:29:in `new' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/snippets/ramaze/state.rb:29:in `wrap' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/adapter/base.rb:120:in `respond' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/adapter/base.rb:111:in `call' /usr/local/lib/ruby/gems/1.8/gems/rack-0.9.1/lib/rack/handler/mongrel.rb:59:in `process' /usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:159:in `process_client' /usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:158:in `each' /usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:158:in `process_client' /usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `run' /usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `initialize' /usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `new' /usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `run' /usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `initialize' /usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `new' /usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `run' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/adapter/mongrel.rb:17:in `startup' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/adapter/base.rb:58:in `start' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/adapter.rb:58:in `start_adapter' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze/adapter.rb:28:in `startup' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze.rb:95:in `start' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze.rb:94:in `each' /Users/me/Dev/Ruby/RamazeGit/lib/ramaze.rb:94:in `start' start.rb:37 Call stack for the first error is below (the second one is much the same).

The notable difference is that you call save! which in turn calls transaction, whereas I call valid? directly, and that doesn’t call transaction. My version of the patch is exactly as downloaded – no modifications.

connection called outside of cleanup_connection block
/usr/local/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:728:in `validates_uniqueness_of’
/usr/local/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:400:in `validates_each’
/usr/local/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:397:in `each’
/usr/local/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:397:in `validates_each’
/usr/local/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:182:in `call’
/usr/local/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:182:in `evaluate_method’
/usr/local/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:166:in `call’
/usr/local/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:90:in `run’
/usr/local/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:90:in `each’
/usr/local/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:90:in `send’
/usr/local/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:90:in `run’
/usr/local/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:277:in `run_callbacks’
/usr/local/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:1029:in `valid_without_callbacks?’
/usr/local/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/callbacks.rb:286:in `valid?’
/Users/me/Dev/Ruby/Test_trunk/lib/crud/crud_instance_methods.rb:76:in `edit_submit’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/template.rb:63:in `__send__’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/template.rb:63:in `render_method’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/template.rb:48:in `result_and_file’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/template.rb:40:in `reaction_or_file’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/template.rb:71:in `wrap_compile’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/template/ezamar.rb:23:in `transform’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/action/render.rb:115:in `uncached_render’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/action/render.rb:39:in `render’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/action/render.rb:11:in `stack’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/action/render.rb:28:in `render’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/controller.rb:266:in `handle’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher/action.rb:29:in `call’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher/action.rb:28:in `catch’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher/action.rb:28:in `call’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher.rb:122:in `filter’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/snippets/ordered_set.rb:49:in `each’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/snippets/ordered_set.rb:49:in `__send__’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/snippets/ordered_set.rb:49:in `method_missing’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher.rb:121:in `filter’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher.rb:109:in `dispatch’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher.rb:108:in `catch’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher.rb:108:in `dispatch’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher.rb:107:in `catch’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher.rb:107:in `dispatch’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher.rb:78:in `general_dispatch’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/dispatcher.rb:53:in `call’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/current.rb:19:in `call’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/reloader.rb:84:in `call’
/usr/local/lib/ruby/gems/1.8/gems/rack-0.9.1/lib/rack/showstatus.rb:20:in `call’
/usr/local/lib/ruby/gems/1.8/gems/rack-0.9.1/lib/rack/showexceptions.rb:23:in `call’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/adapter/base.rb:121:in `respond’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/snippets/ramaze/state.rb:29:in `initialize’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/snippets/ramaze/state.rb:29:in `new’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/snippets/ramaze/state.rb:29:in `wrap’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/adapter/base.rb:120:in `respond’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/adapter/base.rb:111:in `call’
/usr/local/lib/ruby/gems/1.8/gems/rack-0.9.1/lib/rack/handler/mongrel.rb:59:in `process’
/usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:159:in `process_client’
/usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:158:in `each’
/usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:158:in `process_client’
/usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `run’
/usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `initialize’
/usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `new’
/usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:285:in `run’
/usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `initialize’
/usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `new’
/usr/local/lib/ruby/gems/1.8/gems/mongrel-1.1.5/lib/mongrel.rb:268:in `run’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/adapter/mongrel.rb:17:in `startup’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/adapter/base.rb:58:in `start’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/adapter.rb:58:in `start_adapter’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze/adapter.rb:28:in `startup’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze.rb:95:in `start’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze.rb:94:in `each’
/Users/me/Dev/Ruby/RamazeGit/lib/ramaze.rb:94:in `start’
start.rb:37

]]> By: coderrr http://coderrr.wordpress.com/2009/01/16/monkey-patching-activerecord-to-automatically-release-connections/#comment-1288 coderrr Sat, 21 Mar 2009 14:10:11 +0000 http://coderrr.wordpress.com/?p=491#comment-1288 Below is my call chain for a validates_uniqueness_of call. The reason I don't get a warning is because "transaction" is a parent in the call chain, and my monkeypatch wraps transaction with connection_cleanup. So I'm thinking if for some reason you have removed transaction from the wrapped methods, or if for some reason ActiveRecord isn't calling transaction you might get this. Can you show the full stack trace? Mine is: /usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:728:in `validates_uniqueness_of' /usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:400:in `validates_each' /usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:397:in `each' /usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:397:in `validates_each' /usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:182:in `call' /usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:182:in `evaluate_method' /usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:166:in `call' /usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:90:in `run' /usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:90:in `each' /usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:90:in `send' /usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:90:in `run' /usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:277:in `run_callbacks' /usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:1030:in `valid_without_callbacks?' /usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/callbacks.rb:286:in `valid?' /usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:1019:in `save_without_dirty!' /usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/dirty.rb:87:in `save_without_transactions!' /usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/transactions.rb:150:in `save!' /usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/connection_adapters/abstract/database_statements.rb:66:in `transaction' /usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/transactions.rb:129:in `transaction' /usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/transactions.rb:138:in `transaction' /usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/transactions.rb:150:in `save!' /usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/transactions.rb:158:in `rollback_active_record_state!' /usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/transactions.rb:150:in `save!' /usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:991:in `create!' Below is my call chain for a validates_uniqueness_of call. The reason I don’t get a warning is because “transaction” is a parent in the call chain, and my monkeypatch wraps transaction with connection_cleanup.

So I’m thinking if for some reason you have removed transaction from the wrapped methods, or if for some reason ActiveRecord isn’t calling transaction you might get this.

Can you show the full stack trace? Mine is:

/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:728:in `validates_uniqueness_of’
/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:400:in `validates_each’
/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:397:in `each’
/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:397:in `validates_each’
/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:182:in `call’
/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:182:in `evaluate_method’
/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:166:in `call’
/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:90:in `run’
/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:90:in `each’
/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:90:in `send’
/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:90:in `run’
/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/callbacks.rb:277:in `run_callbacks’
/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:1030:in `valid_without_callbacks?’
/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/callbacks.rb:286:in `valid?’
/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:1019:in `save_without_dirty!’
/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/dirty.rb:87:in `save_without_transactions!’
/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/transactions.rb:150:in `save!’
/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/connection_adapters/abstract/database_statements.rb:66:in `transaction’
/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/transactions.rb:129:in `transaction’
/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/transactions.rb:138:in `transaction’
/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/transactions.rb:150:in `save!’
/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/transactions.rb:158:in `rollback_active_record_state!’
/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/transactions.rb:150:in `save!’
/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib/active_record/validations.rb:991:in `create!’

]]> By: Sam http://coderrr.wordpress.com/2009/01/16/monkey-patching-activerecord-to-automatically-release-connections/#comment-1287 Sam Sat, 21 Mar 2009 08:20:46 +0000 http://coderrr.wordpress.com/?p=491#comment-1287 I'm not using Rails, which is why I need this patch in the first place. As it happens I'm using Ramaze, which is fully threaded. It's in a customer project so I can't show code I'm afraid. It's not doing anything very exciting mind you and it always logs the warning when the uniqueness validation fires. What part of the patch should be already covering that case? I’m not using Rails, which is why I need this patch in the first place. As it happens I’m using Ramaze, which is fully threaded.

It’s in a customer project so I can’t show code I’m afraid. It’s not doing anything very exciting mind you and it always logs the warning when the uniqueness validation fires. What part of the patch should be already covering that case?

]]> By: coderrr http://coderrr.wordpress.com/2009/01/16/monkey-patching-activerecord-to-automatically-release-connections/#comment-1286 coderrr Sat, 21 Mar 2009 01:19:01 +0000 http://coderrr.wordpress.com/?p=491#comment-1286 Hrm.... What version of rails are you using? Do you have any code you can show me? I tried a 2.2.2 clean rails proj with a model with a validates_uniqueness_of and didn't get those warnings. Answering whether or not you need to wrap around connection method calls for config uses, the answer is yes. If you don't wrap it, it will still open a connection which will just sit there until your code reaches and finishes a cleanup_connection block. Hrm….

What version of rails are you using? Do you have any code you can show me? I tried a 2.2.2 clean rails proj with a model with a validates_uniqueness_of and didn’t get those warnings.

Answering whether or not you need to wrap around connection method calls for config uses, the answer is yes. If you don’t wrap it, it will still open a connection which will just sit there until your code reaches and finishes a cleanup_connection block.

]]>